Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LocalStorageCapacityIsolation GA #35989

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Update LocalStorageCapacityIsolation GA #35989

merged 1 commit into from
Aug 16, 2022

Conversation

jingxu97
Copy link
Contributor

update feature GA

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2022
@netlify
Copy link

netlify bot commented Aug 15, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d0a4713
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62faace14387af0009a7e0ef

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2022
@jingxu97 jingxu97 marked this pull request as ready for review August 15, 2022 20:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2022
@jingxu97
Copy link
Contributor Author

/assign @xing-yang

@xing-yang
Copy link
Contributor

The content change looks good to me. Not sure why CI failed.

@xing-yang
Copy link
Contributor

From the CI:
ERROR 2022/08/15 20:18:31 "GA" is not a valid feature-state, use one of "alpha, beta, deprecated, stable"

xing-yang
xing-yang reviewed Aug 15, 2022
View reviewed changes
content/en/docs/concepts/configuration/manage-resources-containers.md Outdated
@@ -236,7 +236,7 @@ directly or from your monitoring tools.
## Local ephemeral storage

<!-- feature gate LocalStorageCapacityIsolation -->
{{< feature-state for_k8s_version="v1.10" state="beta" >}}
{{< feature-state for_k8s_version="v1.25" state="GA" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA -> stable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0856710d651f4888459b8077db03019446a3bee

@xing-yang
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot
Copy link
Contributor

@xing-yang: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 15, 2022
Closed
Closed
@kcmartin
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kcmartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@kcmartin
Copy link
Contributor

/milestone 1.25

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 502c6ee into kubernetes:dev-1.25 Aug 16, 2022
@atiratree atiratree mentioned this pull request Apr 17, 2023
Merged
@atiratree
Copy link
Member

Hi, it seems that Local ephemeral storage still incorrectly mentions that it is a beta feature. Posted a fix in #40730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@jimangel jimangel Awaiting requested review from jimangel

@natalisucks natalisucks Awaiting requested review from natalisucks

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@jingxu97 @xing-yang @k8s-ci-robot @kcmartin @atiratree