-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update service.md #7810
Update service.md #7810
Conversation
`securityGroupName` is the required value when creating LoadBalancer type service in Azure. I got the following error without `securityGroupName` value. > Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
Deploy preview for kubernetes-io-master-staging ready! Built with commit 974a3e7 https://deploy-preview-7810--kubernetes-io-master-staging.netlify.com |
/assign heckj |
/lgtm from writing's perspective, need tech review. |
@@ -453,7 +453,8 @@ cloud provider does not support the feature, the field will be ignored. | |||
|
|||
**Special notes for Azure**: To use user-specified public type `loadBalancerIP`, a static type | |||
public IP address resource needs to be created first, and it should be in the same resource | |||
group of the cluster. Then you could specify the assigned IP address as `loadBalancerIP`. | |||
group of the cluster. Then you could specify the assigned IP address as `loadBalancerIP`. You |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be updated to show an example of how loadBalancerIP
and securityGroupName
should be used? The wording as it is highlights that there's things needed, but it's very unclear how to use it or if it's specifically required.
As a suggestion, could you reword this using more imperative, direct english:
Specify the assigned IP address as
loadBalancerIP
. Verify you havesecurityGroupName
in the cloud provider configuration file.
Or something like that?
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heckj, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…elease-1.9 * 'master' of https://github.com/kubernetes/website: (549 commits) Update service.md (#7810) Prune inactive maintainers (#7830) add Amadeus to index page and add feature image (#7827) Update conventions.md (#7668) Adding Tenxcloud as KCSP and Hedvig typo (#7826) Update outdated documentation about secret key validation. (#7675) Update imperative-command.md (#7699) Update manage-deployment.md (#7774) Add the OCI runtime description. (#7769) fix flag (#7814) fix flag (#7813) Add files via upload (#7816) Remove CoreOS guide that use Kubernetes v0.15.0 (#7821) "Nagions" should be "Nagios“ (#7762) Update docker-cli-to-kubectl.md (#7748) adjust a note format (#7812) add a note when mount a configmap to pod (#7745) Make using sysctls a task instead of a concept (#6808) Partners page updates (#7802) Fix a missing word in endpoint reconciler section (#7804) ...
securityGroupName
is the required value when creating LoadBalancer type service in Azure.I got the following error without
securityGroupName
value.