Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload only plugin archives as latest plugins #1287

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Oct 9, 2023

Description

Changes proposed in this pull request:

For the latest plugin release, we use only archive plugins on index.yaml. However, we still push both the binaries and archives making the bucket size to grow.

  • Upload only plugin archives as latest plugins

Testing

Tested on CI branch: https://github.com/kubeshop/botkube/actions/runs/6455472645/job/17523021491?pr=1287

Screenshot 2023-10-09 at 12 51 39

 ▲ gsutil du -s -h gs://botkube-plugins-latest                                                                                                            2s
1.38 GiB     gs://botkube-plugins-latest

 ▲ gsutil du -s -h "gs://botkube-plugins-latest/*.tar.gz"
685.12 MiB   gs://botkube-plugins-latest/*.tar.gz

 ▲ gsutil du -s -h -e "*.tar.gz" gs://botkube-plugins-latest/                                                                                             2s
723.15 MiB   gs://botkube-plugins-latest

Before merge I will clean the whole bucket so binaries will be removed and latest main will push only archives.

@mszostok mszostok added the bug Something isn't working label Oct 9, 2023
@mszostok mszostok force-pushed the narrow-down-gcs-upload branch from 4a17314 to 386bb90 Compare October 9, 2023 11:01
@mszostok mszostok marked this pull request as ready for review October 9, 2023 11:02
@mszostok mszostok requested a review from PrasadG193 as a code owner October 9, 2023 11:02
@mszostok mszostok requested review from a team and huseyinbabal October 9, 2023 11:02
@pkosiec pkosiec removed the request for review from huseyinbabal October 9, 2023 11:02
@mszostok mszostok merged commit bec379c into main Oct 9, 2023
19 checks passed
@mszostok mszostok deleted the narrow-down-gcs-upload branch October 9, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants