Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloud Slack Dev E2E tests after Botkube release #1288

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Oct 9, 2023

Description

Changes proposed in this pull request:

  • Fix Cloud Slack Dev E2E tests after Botkube release
  • Take into account the "upgrade checker" message

Testing

No need, the pipeline tests it: https://github.com/kubeshop/botkube/actions/runs/6457080833

@pkosiec pkosiec added bug Something isn't working ci Related to CI pipelines labels Oct 9, 2023
Copy link
Collaborator Author

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To revert before merge

.github/workflows/branch-build.yml Outdated Show resolved Hide resolved
.github/workflows/branch-build.yml Outdated Show resolved Hide resolved
.github/workflows/branch-build.yml Outdated Show resolved Hide resolved
@pkosiec pkosiec marked this pull request as ready for review October 9, 2023 16:47
@pkosiec pkosiec requested a review from PrasadG193 as a code owner October 9, 2023 16:47
@pkosiec pkosiec requested review from a team and mszostok October 9, 2023 16:47
@pkosiec pkosiec enabled auto-merge (squash) October 10, 2023 07:26
@pkosiec pkosiec disabled auto-merge October 10, 2023 07:57
@pkosiec pkosiec merged commit 5e6aed6 into main Oct 10, 2023
14 checks passed
@pkosiec pkosiec deleted the fix-slack-e2e branch October 10, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Related to CI pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants