Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use main chart in tests #1292

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Use main chart in tests #1292

merged 3 commits into from
Oct 11, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Main charts are published periodically. Now we use that charts in tests

Testing

Related issue(s)

@huseyinbabal huseyinbabal added enhancement New feature or request ci Related to CI pipelines labels Oct 10, 2023
@huseyinbabal huseyinbabal marked this pull request as ready for review October 10, 2023 09:57
@huseyinbabal huseyinbabal requested review from a team and josefkarasek October 10, 2023 09:57
josefkarasek
josefkarasek approved these changes Oct 11, 2023
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huseyinbabal huseyinbabal merged commit 82c612d into kubeshop:main Oct 11, 2023
@huseyinbabal huseyinbabal deleted the use-main-chart branch October 11, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
ci Related to CI pipelines enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @josefkarasek