Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloud teams integration #1298

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add cloud teams integration #1298

merged 2 commits into from
Oct 24, 2023

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Oct 23, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Oct 23, 2023
@mszostok mszostok requested a review from huseyinbabal October 23, 2023 19:34
@mszostok mszostok marked this pull request as ready for review October 23, 2023 19:34
@mszostok mszostok requested a review from PrasadG193 as a code owner October 23, 2023 19:34
@mszostok mszostok requested a review from a team October 23, 2023 19:34
huseyinbabal
huseyinbabal approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 with minor comments

pkg/bot/teams_cloud.go Outdated Show resolved Hide resolved
pkg/bot/teams_cloud_grpc.go Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) October 24, 2023 10:21
@mszostok mszostok merged commit f394c42 into kubeshop:main Oct 24, 2023
15 checks passed
@mszostok mszostok deleted the bootstrap-ms-teams-router branch October 24, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @huseyinbabal