Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Teams gRPC contract, add support for gRPC auth #1301

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Simplify Teams gRPC contract, add support for gRPC auth #1301

merged 1 commit into from
Nov 6, 2023

Conversation

mszostok
Copy link
Collaborator

Description

Changes proposed in this pull request:

  • Simplify Teams gRPC contract, add support for gRPC auth

Releated:

@mszostok mszostok added the enhancement New feature or request label Oct 29, 2023
@mszostok mszostok requested a review from huseyinbabal October 29, 2023 19:23
@mszostok mszostok marked this pull request as ready for review October 29, 2023 19:23
@mszostok mszostok requested a review from PrasadG193 as a code owner October 29, 2023 19:23
@mszostok mszostok requested a review from a team October 29, 2023 19:23
@mszostok mszostok marked this pull request as draft November 1, 2023 01:07
huseyinbabal
huseyinbabal reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an overall review (since it is draft), seems ok to me. After cloud merge I will retest end to end.

@mszostok mszostok marked this pull request as ready for review November 6, 2023 12:10
@huseyinbabal
Copy link
Contributor

I did an overall review (since it is draft), seems ok to me. After cloud merge I will retest end to end.

Did e2e test, works as expected

@mszostok mszostok merged commit 9f08ea6 into kubeshop:main Nov 6, 2023
15 checks passed
@mszostok mszostok deleted the team-auth-grpc branch November 6, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @huseyinbabal