Cloud MS Teams now using remote cfg #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huseyinbabal
force-pushed
the
ms-teams-cfg-gen
branch
from
c0feede to
e4c4ffd
Compare
mszostok
reviewed
Oct 31, 2023
| @@ -81,8 +81,7 @@ func (c *grpcCloudTeamsConnector) Start(ctx context.Context) error { | |||
|
|
|||
| err = activityClient.Send(&pb.AgentActivity{ | |||
| Req: &pb.AgentActivity_InstanceId{ | |||
| //InstanceId: c.remoteConfig.Identifier, // TODO: enable when config generator will work | |||
| InstanceId: "foo-123", | |||
| InstanceId: c.remoteConfig.Identifier, | |||
There was a problem hiding this comment.
please also uncomment code from line 33
mszostok
approved these changes
Oct 31, 2023
huseyinbabal
force-pushed
the
ms-teams-cfg-gen
branch
from
e4c4ffd to
522d7c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
Related issue(s)
Relates https://github.com/kubeshop/botkube-cloud/pull/681