Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit logs and config persistence for Cloud Teams #1312

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Nov 17, 2023

Description

Changes proposed in this pull request:

  • Fix audit logs and config persistence for Cloud Teams

Related issue(s)

@pkosiec pkosiec added the bug Something isn't working label Nov 17, 2023
@pkosiec pkosiec added this to the v1.6.0 milestone Nov 17, 2023
@pkosiec pkosiec force-pushed the fix-ms-teams-persistence branch from 36c41a2 to 9d82e7c Compare November 17, 2023 17:42
@pkosiec pkosiec marked this pull request as ready for review November 20, 2023 10:45
@pkosiec pkosiec requested a review from PrasadG193 as a code owner November 20, 2023 10:45
@pkosiec pkosiec requested review from a team and madebyrogal November 20, 2023 10:45
@huseyinbabal huseyinbabal self-requested a review November 20, 2023 11:00
NodeCount *int `json:"nodeCount"`
CloudSlackUseCount *int `json:"cloudSlackUseCount"`

// All internal, ignored fields are removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this comment? It seems autogenerated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've added it just to ensure we won't bloat models in Botkube Agent with some internal fields from Botkube Cloud 🙂

@huseyinbabal huseyinbabal self-requested a review November 20, 2023 11:09
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

@pkosiec pkosiec merged commit a00cc0c into kubeshop:main Nov 20, 2023
15 checks passed
@pkosiec pkosiec deleted the fix-ms-teams-persistence branch November 20, 2023 11:29
huseyinbabal pushed a commit to huseyinbabal/botkube that referenced this pull request Nov 20, 2023
* Fix audit logs and config persistence for Cloud Teams
* Send additional audit metadata for getting channel name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants