Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt to use regex for json path values #1313

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Nov 20, 2023

Description

Changes proposed in this pull request:

Testing

Config:

        repositories:
          - name: mszostok/gh-test-repo
            on:
              events:
                # IssuesEvent with json path filter
                - type: "IssueCommentEvent"
                  # The JSONPath expression to filter events
                  jsonPath: ".comment.html_url"
                  # The value to match in the JSONPath result
                  value: ".*/pull.*"
                  notificationTemplate:
                    previewTpl: |-
                      Commented on #{{ .Issue.Number }} {{ .Issue.Title }}
                      
                      State:   {{ .Issue.State }}
                      Comment: {{ .Comment.Body }}

                    extraButtons:
                      - displayName: Open
                        url: "{{ .Issue.HTMLURL }}"
                        style: primary

Screenshot 2023-11-20 at 13 10 37

@mszostok mszostok added the enhancement New feature or request label Nov 20, 2023
@mszostok mszostok requested a review from PrasadG193 as a code owner November 20, 2023 12:04
@mszostok mszostok requested review from a team and pkosiec November 20, 2023 12:04
@mszostok mszostok enabled auto-merge (squash) November 20, 2023 12:20
@mszostok mszostok merged commit 966b180 into kubeshop:main Nov 20, 2023
15 checks passed
huseyinbabal pushed a commit to huseyinbabal/botkube that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants