Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Teams apps #1314

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Update Teams apps #1314

merged 2 commits into from
Nov 20, 2023

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Nov 20, 2023

Description

Changes proposed in this pull request:

  • Update Teams apps by adding predefined commands menu:

Screenshot 2023-11-20 at 14 46 47

Note: the "defaultInstallScope": "team" property was removed, as it was probably added manually. We can add it back if needed.

@mszostok mszostok requested a review from PrasadG193 as a code owner November 20, 2023 13:51
@mszostok mszostok requested review from a team, madebyrogal and pkosiec and removed request for madebyrogal November 20, 2023 13:51
@mszostok mszostok added the enhancement New feature or request label Nov 20, 2023
Copy link
Contributor

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to review cos these are binary files. Hope they are working

Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested E2E, works great 👍

@mszostok mszostok merged commit 875f88c into kubeshop:main Nov 20, 2023
15 checks passed
@mszostok mszostok deleted the update-teams-apps branch November 20, 2023 15:54
mszostok added a commit to mszostok/botkube that referenced this pull request Nov 20, 2023
* Add 'defaultInstallScope' property

---------

Co-authored-by: Pawel Kosiec <[email protected]>
@mszostok mszostok mentioned this pull request Nov 20, 2023
pkosiec added a commit that referenced this pull request Nov 20, 2023
Update Teams apps (#1314)

* Add 'defaultInstallScope' property

---------

Co-authored-by: Pawel Kosiec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants