Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentationURL to plugins #1320

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add documentationURL to plugins #1320

merged 2 commits into from
Nov 27, 2023

Conversation

madebyrogal
Copy link
Contributor

@madebyrogal madebyrogal commented Nov 27, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add Documentation URL to plugins

Testing

  • rebuild your local plugins make build-plugins-single
  • run your local plugin index server go run test/helpers/plugin_server.go
  • open browser on (in my case it was http://localhost:3010/botkube.yaml)
  • check if you can see documentationUrl fill in with the link to our docs for each plugin

Related issue(s)

https://github.com/kubeshop/botkube-cloud/issues/649

@madebyrogal madebyrogal changed the title add documentationURL to plugins Add documentationURL to plugins Nov 27, 2023
@madebyrogal madebyrogal marked this pull request as ready for review November 27, 2023 13:31
@madebyrogal madebyrogal requested review from a team and huseyinbabal November 27, 2023 13:31
@madebyrogal madebyrogal added the enhancement New feature or request label Nov 27, 2023
@madebyrogal madebyrogal requested a review from pkosiec November 27, 2023 13:38
pkosiec
pkosiec approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! LGTM

internal/plugin/index.go Outdated Show resolved Hide resolved
@madebyrogal madebyrogal merged commit fbf9ccb into kubeshop:main Nov 27, 2023
15 checks passed
@madebyrogal madebyrogal deleted the modify-schema-for-yaml-editor branch November 27, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

@huseyinbabal huseyinbabal Awaiting requested review from huseyinbabal

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madebyrogal @pkosiec