Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore empty botkube repositories url during cli test #1325

Merged
merged 1 commit into from
Dec 1, 2023
Merged

ignore empty botkube repositories url during cli test #1325

merged 1 commit into from
Dec 1, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Handled empty repository URL to use the default one. Default one is provided already here

    botkube/test/e2e/migration_test.go

    Line 41 in 6c85373

    --set plugins.repositories.botkube.url=https://storage.googleapis.com/botkube-plugins-latest/plugins-index.yaml \

Testing

Related issue(s)

@huseyinbabal huseyinbabal requested review from a team, madebyrogal and pkosiec and removed request for madebyrogal December 1, 2023 08:34
@huseyinbabal huseyinbabal added the other Internal, no user-facing changes. label Dec 1, 2023
@huseyinbabal huseyinbabal merged commit 871c9f3 into kubeshop:main Dec 1, 2023
15 of 16 checks passed
@huseyinbabal huseyinbabal deleted the fix-cli-migration-test branch December 1, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
other Internal, no user-facing changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @pkosiec