Support channel-based group mapping for Cloud Teams #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
handle-channel-mapping-teams
branch
from
dc0a32f to
9734796
Compare
mszostok
approved these changes
Dec 4, 2023
| @@ -81,9 +81,16 @@ func (e *PluginExecutor) Execute(ctx context.Context, bindings []string, slackSt | |||
| return interactive.CoreMessage{}, fmt.Errorf("while collecting configs: %w", err) | |||
| } | |||
|
|
|||
| channel := cmdCtx.Conversation.DisplayName | |||
There was a problem hiding this comment.
it may be useful to put it in the docs 👍
There was a problem hiding this comment.
Not sure, honestly, as we use channel name for all platforms: https://docs.botkube.io/configuration/rbac#mapping-types
The fallback I did is for e.g. new platforms if we forget passing display name.
Does it make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
You can run Botkube against Botkube Cloud with
export BOTKUBE_SETTINGS_LOG_LEVEL=debug.And then see something like:
or