Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON schemas for all plugins #1328

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Dec 4, 2023

Description

Changes proposed in this pull request:

  • Update JSON schemas for all plugins
    • Add password format for credentials
    • Ensure log is exposed everywhere
    • Ensure additionalProperties are enabled for plugins with more complex data
  • Unify JSON schema definition across all plugins

Testing

  • rebuild your local plugins make build-plugins-single
  • run your local plugin index server go run test/helpers/plugin_server.go
  • use http://localhost:3010/botkube.yaml as plugin repository for Botkube Cloud
  • Create instance and see the plugin list. Enable all of them and see the YAML editor + UI forms.
    • See that all the propoerties are already filled-in in the yaml editor
    • See that the password fields are properly visible in UI form

image

Related issue(s)

@pkosiec pkosiec added the enhancement New feature or request label Dec 4, 2023
@pkosiec pkosiec force-pushed the update-json-schemas branch from 3d270d3 to 4758e19 Compare December 4, 2023 22:07
@pkosiec pkosiec marked this pull request as ready for review December 5, 2023 14:02
@pkosiec pkosiec requested a review from PrasadG193 as a code owner December 5, 2023 14:02
@pkosiec pkosiec requested review from a team and huseyinbabal December 5, 2023 14:02
@huseyinbabal
Copy link
Contributor

huseyinbabal commented Dec 6, 2023

@pkosiec Keptn and Doctor plugins has confidental data but they seem like plain text, any reason for that?
Screenshot 2023-12-06 at 12 17 50
Screenshot 2023-12-06 at 12 18 02

@pkosiec
Copy link
Collaborator Author

pkosiec commented Dec 6, 2023

@huseyinbabal are you sure you're using the latest schemas and the latest UI? In the PR desc I posted a screenshot how it should look like

@huseyinbabal
Copy link
Contributor

@huseyinbabal are you sure you're using the latest schemas and the latest UI? In the PR desc I posted a screenshot how it should look like

I checkout this pr branch and built all the indexes, and using as botkube cloud plugin repository. I will double check and get back to you

Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🚀

@pkosiec pkosiec merged commit b920662 into kubeshop:main Dec 6, 2023
17 checks passed
@pkosiec pkosiec deleted the update-json-schemas branch December 6, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants