Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add origin extraction for cmd execution, add user display name for interactive command #1330

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Add origin extraction for cmd execution, add user display name for interactive command #1330

merged 2 commits into from
Dec 13, 2023

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Dec 11, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add user display name for interactive command responses.
  • Introduce a feature that allows explicit origin extraction for the execution of commands. Furthermore, for commands that do not have an explicit origin property, a fallback strategy has been implemented to determine the command origin based on activity type.

Related issue(s)

Fix https://github.com/kubeshop/botkube-cloud/issues/739

@mszostok
Add origin extraction for cmd execution, add user display name for in…
97f4593 
…teractive command

The changes introduce a feature that allows explicit origin extraction for the execution of commands. Furthermore, for commands that do not have an explicit origin, a fallback strategy has been implemented to determine the command origin based on activity type.
@mszostok mszostok added the enhancement New feature or request label Dec 11, 2023
@mszostok mszostok requested a review from pkosiec December 11, 2023 20:46
@mszostok mszostok marked this pull request as ready for review December 11, 2023 20:46
@mszostok mszostok requested a review from PrasadG193 as a code owner December 11, 2023 20:46
@mszostok mszostok requested a review from a team December 11, 2023 20:46
pkosiec
pkosiec approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 works well

internal/remote/graphql/connected_platforms.go Outdated Show resolved Hide resolved
pkg/bot/teams_cloud.go Outdated Show resolved Hide resolved
pkg/bot/teams_cloud.go Show resolved Hide resolved
pkosiec
pkosiec reviewed Dec 12, 2023
View reviewed changes
pkg/bot/teams_cloud.go Outdated Show resolved Hide resolved
@mszostok mszostok force-pushed the add-plaintext-mention branch from 0c4047d to 0b615b8 Compare December 12, 2023 13:22
@mszostok mszostok enabled auto-merge (squash) December 12, 2023 13:22
@mszostok mszostok merged commit 8c46be5 into kubeshop:main Dec 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec