Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TLS encryption for gRPC connections in Cloud Slack and Teams #1332

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Support TLS encryption for gRPC connections in Cloud Slack and Teams #1332

merged 2 commits into from
Dec 15, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Dec 14, 2023

Description

Changes proposed in this pull request:

  • Support TLS encryption for gRPC connections in Cloud Slack and Teams

Testing

Test it E2E with the changes on Cloud.

@pkosiec pkosiec added the enhancement New feature or request label Dec 14, 2023
@pkosiec pkosiec marked this pull request as ready for review December 14, 2023 12:34
@pkosiec pkosiec requested a review from PrasadG193 as a code owner December 14, 2023 12:34
@pkosiec pkosiec requested review from a team and huseyinbabal December 14, 2023 12:34
@pkosiec pkosiec marked this pull request as draft December 14, 2023 12:34
@pkosiec pkosiec requested review from mszostok and removed request for huseyinbabal December 14, 2023 14:50
@pkosiec pkosiec marked this pull request as ready for review December 14, 2023 14:50
mszostok
mszostok approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

pkg/grpcx/credentials.go Outdated Show resolved Hide resolved
@pkosiec
Copy link
Collaborator Author

pkosiec commented Dec 15, 2023

Merging as integration tests will fail for Slack until we have new Botkube Cloud on Dev 👍

@pkosiec pkosiec merged commit 2955f95 into kubeshop:main Dec 15, 2023
13 of 15 checks passed
@pkosiec pkosiec deleted the grpc-tls branch December 15, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@mszostok mszostok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @mszostok