Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended flag to plugin index #1339

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

madebyrogal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add recommended flag to plugin index

Testing

  • run plugin index locally
  • check if server returns recommended flag (for kubectl & k8s should be true)

Related issue(s)

https://github.com/kubeshop/botkube-cloud/issues/732

@madebyrogal madebyrogal marked this pull request as ready for review December 20, 2023 16:04
@madebyrogal madebyrogal requested review from a team and pkosiec December 20, 2023 16:04
@madebyrogal madebyrogal added the enhancement New feature or request label Dec 20, 2023
@pkosiec pkosiec requested review from pkosiec and mszostok and removed request for pkosiec December 22, 2023 10:06
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minior doc comment, besides that LGTM 🚀

pkg/api/plugin.go Outdated Show resolved Hide resolved
@madebyrogal madebyrogal merged commit f000b15 into kubeshop:main Dec 27, 2023
15 checks passed
@madebyrogal madebyrogal deleted the recommended-plugins branch December 27, 2023 12:54
@pkosiec pkosiec changed the title ADD recommended flag to plugin index Add recommended flag to plugin index Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants