Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redacting credentials and hide CA certificate when showing config #1340

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix redacting credentials and hide CA certificate when showing config #1340

merged 1 commit into from
Dec 22, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Dec 22, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix redacting credentials when showing config
  • Hide CA cert as it makes the config unreadable

Testing

Screenshot 2023-12-22 at 11 03 08

@pkosiec pkosiec added the bug Something isn't working label Dec 22, 2023
@pkosiec pkosiec added this to the v1.8.0 milestone Dec 22, 2023
@pkosiec pkosiec requested a review from PrasadG193 as a code owner December 22, 2023 10:04
@pkosiec pkosiec requested review from a team and mszostok December 22, 2023 10:04
@pkosiec pkosiec changed the title Fix redacting credentials when showing config Fix redacting credentials and hide CA certificate when showing config Dec 22, 2023
@pkosiec pkosiec enabled auto-merge (squash) December 22, 2023 10:28
@pkosiec pkosiec merged commit ecd86f6 into kubeshop:main Dec 22, 2023
20 checks passed
@pkosiec pkosiec deleted the fix-redacted-cfg branch December 22, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @mszostok