Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slight confusion in agent built bin name #1342

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix slight confusion in agent built bin name #1342

merged 1 commit into from
Jan 3, 2024

Conversation

vaijab
Copy link
Contributor

@vaijab vaijab commented Jan 3, 2024

Description

Changes proposed in this pull request:

  • Remove make build target since it's not used anywhere.
  • Make sure botkube agent binary is name botkube-agent.
  • Incidental markdown lint fixes.

Testing

Related issue(s)

@vaijab vaijab requested a review from PrasadG193 as a code owner January 3, 2024 13:19
@vaijab vaijab requested review from a team and pkosiec January 3, 2024 13:19
@vaijab vaijab added documentation Documetation is missing or incorrect contributor experience labels Jan 3, 2024
pkosiec
pkosiec approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for spotting and fixing the issue!

@pkosiec
Copy link
Collaborator

pkosiec commented Jan 3, 2024

BTW @vaijab, could you also synchronize the changes to the botkube-docs repo, where we have the same contributing guide hosted on the website?
URL: https://docs.botkube.io/community/contribute/
Source file: https://github.com/kubeshop/botkube-docs/blob/main/community/contribute/index.md

It can be done later, as I believe you'll spot some issues in the docs during Botkube walkthrough 🙂 Thanks in advance!

@vaijab vaijab merged commit ea059f3 into main Jan 3, 2024
20 of 21 checks passed
@vaijab vaijab deleted the fixbuildtgt branch January 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
contributor experience documentation Documetation is missing or incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaijab @pkosiec