Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cloud Slack e2e test resiliency around Slack workspace connect #1352

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Improve Cloud Slack e2e test resiliency around Slack workspace connect #1352

merged 5 commits into from
Jan 17, 2024

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Jan 17, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Improve Cloud Slack e2e test resiliency

After connecting Slack workspace, the homepage sometimes isn't able to fully load. I'm not sure why, that's why this PR introduces:

  • screenshot after connecting Slack workspace, when homepage can't be loaded
  • continuing the tests with an error, to make sure the Slack workspace is properly disconnected

Testing

No need - CI verifies it:

@pkosiec pkosiec added ci Related to CI pipelines other Internal, no user-facing changes. labels Jan 17, 2024
@pkosiec pkosiec changed the title Improve Cloud Slack e2e test resiliency Improve Cloud Slack e2e test resiliency around Slack workspace connect Jan 17, 2024
@pkosiec pkosiec marked this pull request as ready for review January 17, 2024 13:58
@pkosiec pkosiec requested a review from PrasadG193 as a code owner January 17, 2024 13:58
@pkosiec pkosiec requested review from a team and madebyrogal January 17, 2024 13:58
madebyrogal
madebyrogal approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to clean up commented lines

@pkosiec pkosiec merged commit 52e8e13 into main Jan 17, 2024
11 checks passed
@pkosiec pkosiec deleted the improve-slack-e2e-test-resiliency branch January 17, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebyrogal madebyrogal madebyrogal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
ci Related to CI pipelines other Internal, no user-facing changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @madebyrogal