Migrate disabled plugins to Cloud

[madebyrogal]

Description

Changes proposed in this pull request:

• migrate disabled plugin
• fix missing displayName during migration
• fix RBAC conversion
• fix installation command abort update existing instalation

Testing

Test this against Botkube Cloud dev setup (UI and BE).

Check out the PR and build the latest CLI:

export IMAGE_TAG=v9.99.9-dev
make release-snapshot-cli
chmod +x ./dist/botkube-cli_darwin_amd64_v1/botkube && cp ./dist/botkube-cli_darwin_amd64_v1/botkube /usr/local/bin/botkube_dev

Then, install Botkube in your k3d cluster

export ALLOW_KUBECTL=true
export ALLOW_HELM=true
export SLACK_CHANNEL_NAME=botkube-demo \
export SLACK_API_APP_TOKEN=xapp-... \
export SLACK_API_BOT_TOKEN=xoxb-... \
export CLUSTER_NAME=dev
botkube_dev install --version 1.7.0 \
--set communications.default-group.socketSlack.enabled=true \
--set communications.default-group.socketSlack.channels.default.name=${SLACK_CHANNEL_NAME} \
--set communications.default-group.socketSlack.appToken=${SLACK_API_APP_TOKEN} \
--set communications.default-group.socketSlack.botToken=${SLACK_API_BOT_TOKEN} \
--set settings.clusterName=${CLUSTER_NAME} \
--set 'executors.k8s-default-tools.botkube/kubectl.enabled'=${ALLOW_KUBECTL} \
--set 'executors.k8s-default-tools.botkube/helm.enabled'=${ALLOW_HELM}

Then you will be asked about updating existing instance (test both options)

• option 1: update existing instance
• option 2: don't update

Each time check if you can see disabled plugins in UI

Related issue(s)

[pkosiec]

Didn't test it, just code review. Please update Migration E2E integration tests to cover the new functionality and after that (plus fixing the minor comments) I'll test the PR E2E 🙂 Thanks!

Hint: you can open a new PR based on this one using branch on the upstream repo, to be able to trigger the migration tests there.

[pkosiec]

LGTM, good work!