-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teams/integration tests #1361
Merged
Merged
Teams/integration tests #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
teams/integration-tests
branch
7 times, most recently
from
January 25, 2024 21:14
3693f69
to
fa81694
Compare
mszostok
force-pushed
the
teams/integration-tests
branch
12 times, most recently
from
January 29, 2024 16:23
48317d7
to
725a88e
Compare
mszostok
commented
Jan 30, 2024
mszostok
force-pushed
the
teams/integration-tests
branch
3 times, most recently
from
January 30, 2024 10:01
de598a8
to
5d96daa
Compare
mszostok
force-pushed
the
teams/integration-tests
branch
from
January 30, 2024 10:11
5d96daa
to
a09d4d2
Compare
mszostok
commented
Jan 30, 2024
pkosiec
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🚀 Just some small comments.
mszostok
force-pushed
the
teams/integration-tests
branch
from
January 30, 2024 22:29
a09d4d2
to
5352cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
SendMessageToAll
fn: https://github.com/kubeshop/botkube/pull/1361/files#diff-a9f0c7bc7b088492810cc5f07cf8e2065acc85a188440c1fa84f12847963862fR124go.mod
for e2e tests and usebotkube-cloud
as private dependency.Follow-up issues
Testing
Overall testing approach:
html
msg we convert that to markdown and do use strings comparisonjsondiff
libraryVerified by CI:
another run but without first restart in Teams platform:
Related issue(s)