Reorganize migrate constaints check and add unit tests #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
fix-migrate-constraint
branch
from
64a7725 to
1d2fe77
Compare
mszostok
approved these changes
Jan 26, 2024
madebyrogal
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
After I found out an issue on 1.8.0-rc.1, I've reorganized the code a bit and also wrote some unit tests to check how it behaves.
Unfortunately this is a known issue Masterminds/semver#177, but as we can encounter it only on RC versions, I think it's a very low priority one.
This PR doesn't need to be cherry-picked for final 1.8.
Testing
See test instruction from #1353