Bump github.com/gin-gonic/gin from 1.8.1 to 1.9.1 #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
added
dependencies
mszostok
force-pushed
the
bump-deps
branch
2 times, most recently
from
c57e24f to
06743d2
Compare
pkosiec
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Unfortunately, we are not able to access secrets so we are not able to download deps:
To overcome this issue, I just delete the imports formatting from the
e2etests. The other option would be to use thepull_request_targetand then check out the code, but then they will also have access to the token, so malicious code still can download the git repo and steal it. I don't think that losing the import sorting for e2e is a big problem here.