Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugin-related internal packages to pkg #1373

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Move plugin-related internal packages to pkg #1373

merged 1 commit into from
Feb 8, 2024

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Feb 7, 2024

Description

Changes proposed in this pull request:

  • Move plugin-related internal packages to pkg

@pkosiec pkosiec added enhancement New feature or request refactor Code refactoring. No functional changes other Internal, no user-facing changes. and removed enhancement New feature or request labels Feb 7, 2024
@pkosiec pkosiec marked this pull request as ready for review February 7, 2024 17:17
@pkosiec pkosiec requested a review from PrasadG193 as a code owner February 7, 2024 17:17
@pkosiec pkosiec requested review from a team and mszostok February 7, 2024 17:17
@pkosiec pkosiec mentioned this pull request Feb 7, 2024
Merged
mszostok
mszostok approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaijab
Copy link
Contributor

vaijab commented Feb 8, 2024

What does x suffix mean in package names?

@mszostok
Copy link
Collaborator

mszostok commented Feb 8, 2024

@vaijab x stands for extension in this context

@pkosiec pkosiec merged commit f6ec67a into kubeshop:main Feb 8, 2024
20 checks passed
@pkosiec pkosiec deleted the move-internal-to-pkg branch February 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@vaijab vaijab vaijab approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
other Internal, no user-facing changes. refactor Code refactoring. No functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkosiec @vaijab @mszostok