Update setup-go action #1375
Merged
Update setup-go action #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
added
ci
pkosiec
approved these changes
Feb 8, 2024
mszostok
commented
Feb 8, 2024
| @@ -380,16 +378,13 @@ func TestCloudSlackE2E(t *testing.T) { | |||
|
|
|||
| t.Log("Testing ping for not connected deployment #2") | |||
| command = "ping" | |||
| expectedBlockMessage := notConnectedMessage(deployment2.Name, deployment2.ID) | |||
| expectedMessage = fmt.Sprintf("The cluster %s (id: %s) is not connected.", deployment2.Name, deployment2.ID) | |||
There was a problem hiding this comment.
In my opinion, we don't need to do the exact match here. Those test checks for the overall flow. The more strict approach for checking messages is implemented in the integration tests. WDYT @pkosiec?
I proved that it is passing here: https://github.com/kubeshop/botkube/actions/runs/7836309606
and here is the one that is not passing on the main: https://github.com/kubeshop/botkube/actions/runs/7832221693/job/21380797568
mszostok
force-pushed
the
update-action
branch
from
0d48a08 to
e2c29fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: