Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helm chart upgrade when using existing secret #1378

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

voriol
Copy link
Contributor

@voriol voriol commented Feb 12, 2024

Description

Bug in the Helm chart when using existing secret

Error: template: sre-botkube/charts/botkube/templates/persistent-config.yaml:6:23: executing "sre-botkube/charts/botkube/templates/persistent-config.yaml" at <index $secret.data "comm_config.yaml">: error calling index: index of untyped nil

Related issue(s)

Fixes #1376.

@voriol voriol requested a review from PrasadG193 as a code owner February 12, 2024 08:40
@voriol voriol requested review from a team and vaijab February 12, 2024 08:40
@mszostok mszostok added the bug Something isn't working label Feb 12, 2024
@pkosiec pkosiec self-assigned this Feb 13, 2024
@pkosiec pkosiec requested review from pkosiec and removed request for vaijab February 13, 2024 08:24
@pkosiec pkosiec changed the title bug in the Helm chart when using existing secret Fix Helm chart upgrade when using existing secret Feb 13, 2024
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - glad this worked for you!

@pkosiec pkosiec enabled auto-merge (squash) February 13, 2024 09:40
@pkosiec pkosiec disabled auto-merge February 13, 2024 10:50
@pkosiec pkosiec merged commit bc62399 into kubeshop:main Feb 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm upgrade with existingCommunicationsSecretName fails
3 participants