-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubectl builder perms checker #1380
Conversation
ada00cc
to
0208b3c
Compare
0208b3c
to
8491a77
Compare
CI tests are failing in the same way on We need to investigate that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and demo LGTM 🚀 didn't test it personally, but I'll try it out after releasing the latest main plugins 👍
@@ -26,7 +26,7 @@ func main() { | |||
portInt, err := strconv.Atoi(port) | |||
loggerx.ExitOnError(err, "while starting server") | |||
|
|||
binDir := filepath.Join(dir, "plugin-dist") | |||
binDir := filepath.Join(dir, "../plugin-dist") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason if this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests no have own go.mod
you need to run server from tests
folder and it breaks the flow as the dir
is taken from the current path 🙂
8491a77
to
0c63234
Compare
Description
Changes proposed in this pull request:
Testing
Demo recording uploaded to Slack as it doesn't fit GitHub limits: https://kubeshop.slack.com/archives/C03MRCX7UE9/p1707757327981479?thread_ts=1707493295.011349&cid=C03MRCX7UE9
Here is the config that I used for testing:
YAML Config
Related issue(s)
Fix #1379