Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom headers during plugin index request #1381

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Feb 12, 2024

Description

Changes proposed in this pull request:

  • Support custom headers during plugin index request
  • Fix returning errors for CLI migration

Testing

Test it E2E using the other PR with custom plugin index endpoint.

@pkosiec pkosiec added the enhancement New feature or request label Feb 12, 2024
internal/plugin/manager.go Fixed Show fixed Hide fixed
@pkosiec pkosiec force-pushed the plugin-index-customization branch 4 times, most recently from 33bc3e1 to 78d3fde Compare February 16, 2024 23:14
@pkosiec pkosiec marked this pull request as ready for review February 16, 2024 23:14
@pkosiec pkosiec requested a review from PrasadG193 as a code owner February 16, 2024 23:14
@pkosiec pkosiec requested review from a team and mszostok February 16, 2024 23:14
@pkosiec pkosiec force-pushed the plugin-index-customization branch 2 times, most recently from 6ad2cd0 to d68bd64 Compare February 19, 2024 08:33
@pkosiec pkosiec force-pushed the plugin-index-customization branch from d3ff57c to 2a29cca Compare February 19, 2024 12:47
@pkosiec pkosiec requested a review from madebyrogal February 20, 2024 13:04
Copy link
Contributor

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment / question
Beside that. Well done!

pkg/config/config.go Show resolved Hide resolved
@pkosiec pkosiec force-pushed the plugin-index-customization branch from 50d7870 to 10d9e43 Compare February 20, 2024 14:30
@pkosiec pkosiec merged commit 148a9ed into kubeshop:main Feb 20, 2024
10 checks passed
@pkosiec pkosiec deleted the plugin-index-customization branch February 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants