Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update executor contract, publish local dev server #1385

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Feb 15, 2024

Description

Changes proposed in this pull request:

  • Update executor contract, publish local dev server

Testing

Described here: kubeshop/botkube-plugins#3

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Feb 15, 2024
@mszostok mszostok force-pushed the boilerplate-plugins branch from 9b4ef50 to e7ea884 Compare February 15, 2024 09:12
@mszostok
Copy link
Collaborator Author

Note

The cloud integration tests will not pass because the Agent is incompatible with the latest plugins from main. It will be automatically fixed when we merge this pull request, and new plugins are released.

@mszostok mszostok requested a review from vaijab February 15, 2024 10:51
@mszostok mszostok marked this pull request as ready for review February 15, 2024 10:51
@mszostok mszostok requested a review from PrasadG193 as a code owner February 15, 2024 10:51
@mszostok mszostok requested a review from a team February 15, 2024 10:51
Copy link
Contributor

@vaijab vaijab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

proto/executor.proto Show resolved Hide resolved
@mszostok mszostok force-pushed the boilerplate-plugins branch 2 times, most recently from 8704d1d to 5443d9d Compare February 19, 2024 11:01
@mszostok mszostok force-pushed the boilerplate-plugins branch from 5443d9d to 2104f93 Compare February 19, 2024 11:19
@mszostok mszostok merged commit 577e1e8 into kubeshop:main Feb 19, 2024
12 checks passed
@mszostok mszostok deleted the boilerplate-plugins branch February 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants