hotfix: fix controller panic (#2579)

kubeshop · May 24, 2023 · c7dfad9 · c7dfad9
1 parent e1b4bef
commit c7dfad9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/server/http/controller.go b/server/http/controller.go
@@ -537,16 +537,19 @@ func (c *controller) executeTransaction(ctx context.Context, transaction tests.T
 	resp, err := c.doCreateTransaction(ctx, transaction)
 	if err != nil {
 		if errors.Is(err, errTransactionExists) {
-			resp, err := c.doUpdateTransaction(ctx, transaction.ID, transaction)
+			resp, err = c.doUpdateTransaction(ctx, transaction.ID, transaction)
 			if err != nil {
 				return resp, err
 			}
 		} else {
 			return resp, err
 		}
+	} else {
+		// the transaction was created, make sure we have the correct ID
+		transaction = resp.Body.(tests.Transaction)
 	}
 
-	transactionID := resp.Body.(tests.Transaction).ID
+	transactionID := transaction.ID
 
 	// transaction ready, execute it
 	resp, err = c.RunTransaction(ctx, transactionID.String(), runInfo)

diff --git a/testing/server-tracetesting/run.bash b/testing/server-tracetesting/run.bash
@@ -8,7 +8,7 @@ if ! command -v "$TRACETEST_CLI" &> /dev/null; then
   exit 2
 fi
 
-export TARGET_URL=${TARGET_URL:-"http://localhost:8081"}
+export TARGET_URL=${TARGET_URL:-"http://localhost:11633"}
 if [  "$TARGET_URL" = "" ]; then
   echo "\$TARGET_URL not set";
   exit 2