fix: unescape strings before comparing them (#3928)

kubeshop · Jul 9, 2024 · fc18f9c · fc18f9c
1 parent 2a9475c
commit fc18f9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/server/expression/executor.go b/server/expression/executor.go
@@ -211,7 +211,8 @@ func (e Executor) resolveTerm(term *Term) (value.Value, error) {
 			strValue = fmt.Sprintf(term.Str.Text, stringArgs...)
 		}
 
-		return value.NewFromString(strValue), nil
+		str := value.NewFromString(strValue)
+		return value.NewFromString(str.UnescappedString()), nil
 	}
 
 	return value.Nil, fmt.Errorf("empty term")

diff --git a/server/expression/executor_test.go b/server/expression/executor_test.go
@@ -58,6 +58,11 @@ func TestBasicExpressionExecution(t *testing.T) {
 			Query:      `100ms < 200 ms`,
 			ShouldPass: true,
 		},
+		{
+			Name:       "escaped_strings_must_be_equal_to_unescaped_strings",
+			Query:      `'This should be workin\'' = "This should be workin'"`,
+			ShouldPass: true,
+		},
 	}
 
 	executeTestCases(t, testCases)