Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix deployment page to match new config file #2240

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes a config file in the deployment overview page (docs).

Changes

  • Fix docs

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc added the documentation Improvements or additions to documentation label Mar 23, 2023
@jorgeepc jorgeepc self-assigned this Mar 23, 2023
telemetry:
dataStore: jaeger
exporter: collector
applicationExporter: collector
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a mention of the tracetest-provision.yaml file here?
@jorgeepc @xoscar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have that as a separate PR focused on explaining the provisioning file and have this cleaned up asap so users are not confused.

@xoscar xoscar merged commit 48efb1a into main Mar 24, 2023
@xoscar xoscar deleted the 2237-fix-deployment-docs branch March 24, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants