Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quick start Example] Adding example with Sinatra #2319

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

danielbdias
Copy link
Contributor

This PR adds a simple example of a Tracetest test running against a Ruby API

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @danielbdias I tried to run this example but I'm getting the following

Screenshot 2023-04-10 at 9 41 40

After running docker compose up

Also, what's your plan on updating the docs website recipes?

@@ -0,0 +1,9 @@
# Quick Start - Ruby app with OpenTelemetry and Tracetest

> [Read the detailed recipe for setting up OpenTelemetry Collector with Tractest in our documentation.](https://docs.tracetest.io/examples-tutorials/recipes/running-tracetest-without-a-trace-data-store)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update this before merging? Are you planning to add the recipe documentation afterward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 , I'm using the same description we used on Node.js, Python, and Golang READMEs.
We can review these descriptions and write a better explanation for them in other PR. Let's talk with @adnanrahic about this.

Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job my dude!

@danielbdias danielbdias merged commit 8c89362 into main Apr 10, 2023
@danielbdias danielbdias deleted the add/ruby-sinatra-example branch April 10, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants