feature: Azure Application Insights Integration #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
changed the title
xoscar
requested review from
danielbdias,
schoren,
kdhamric,
mathnogueira and
olha23
xoscar
added
the
tracing backend
xoscar
changed the title
xoscar
commented
Jun 8, 2023
| type: boolean | ||
| accessToken: | ||
| type: string | ||
| connectionType: |
There was a problem hiding this comment.
I think this connection type is something we can move to be part of the base data store object, I don't want to do it now but it will be very useful in the future
xoscar
commented
Jun 8, 2023
| @@ -202,21 +223,26 @@ func (ds DataStore) GetID() id.ID { | |||
| } | |||
|
|
|||
| func (ds DataStore) IsOTLPBasedProvider() bool { | |||
| if ds.Type == DatastoreTypeAzureAppInsights { | |||
There was a problem hiding this comment.
In the future, I'd prefer having each integrator decide if they are otlp or not based on the values and such. this patch is temporary
xoscar
deleted the
2590-add-microsoft-application-insights-as-a-supported-trace-datastore
branch
mathnogueira
pushed a commit
that referenced
this pull request
Jun 13, 2023
* save commit * feature: Azure Application Insights Datastore Integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Azure Application Insights data store integration
Changes
Fixes
Checklist
https://www.loom.com/share/6ff8f264bb7748329050ca0132c71aa7