-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting running cli in docker #2724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documenting how to run the CLI inside of docker
jfermi
reviewed
Jun 13, 2023
jfermi
reviewed
Jun 13, 2023
jfermi
reviewed
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few editing suggestions.
Co-authored-by: Julianne Fermi <[email protected]>
Co-authored-by: Julianne Fermi <[email protected]>
schoren
reviewed
Jun 14, 2023
schoren
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! might be easier to read if using host networking mode in docker, but that's a subjective opinion
Co-authored-by: Sebastian Choren <[email protected]>
mathnogueira
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Documenting running cli in docker Documenting how to run the CLI inside of docker * Update docs/docs/ci-cd-automation/overview.md Co-authored-by: Julianne Fermi <[email protected]> * Update docs/docs/cli/configuring-your-cli.md Co-authored-by: Julianne Fermi <[email protected]> * Update docs/docs/cli/configuring-your-cli.md Co-authored-by: Sebastian Choren <[email protected]> --------- Co-authored-by: Julianne Fermi <[email protected]> Co-authored-by: Sebastian Choren <[email protected]>
mathnogueira
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Documenting running cli in docker Documenting how to run the CLI inside of docker * Update docs/docs/ci-cd-automation/overview.md Co-authored-by: Julianne Fermi <[email protected]> * Update docs/docs/cli/configuring-your-cli.md Co-authored-by: Julianne Fermi <[email protected]> * Update docs/docs/cli/configuring-your-cli.md Co-authored-by: Sebastian Choren <[email protected]> --------- Co-authored-by: Julianne Fermi <[email protected]> Co-authored-by: Sebastian Choren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding docs in two places per #2611 to document how to use the Tracetest image to run the CLI in docker without installing locally.