fix(cicd): make pull request pipeline work as expected for push to main #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
changed the title
test test test test test test test
schoren
force-pushed
the
fix-pipeline-image-tag
branch
from
4987c80 to
c29914f
Compare
danielbdias
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the pull request pipeline so it can work as expected when triggered both by a PR or by a push to main.
When running on main, the images were exported with the tag
kubeshop/tracetest:pr-. This is because the pipeline relies on the PR number to build that tag. The problem is that sometimes the cache can be picked by a PR that will try to run images with the tagkubeshop/tracetest:pr-{the pr number}. Since the image is exported with the wrong tag, the docker stack cannot start and everything fails.This happens by removing the references to PR specific info, like PR number, and replacing it by the sha of whatever commit triggered the action.