-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add observability to the rescue example #2736
Conversation
This is beautiful. 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Added some comments for the readme.
# internal error! | ||
``` | ||
|
||
## Trace-based tests that you can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a short description of what these two tests are doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
bc0e32f
to
d2acf6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't know ruby very well though
# --- | ||
# type: Analyzer | ||
# spec: | ||
# id: current | ||
# name: Analyzer | ||
# enabled: false | ||
# minimumScore: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for having this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because the Analyzer provisioning is broken for empty plugins. @xoscar solved it yesterday and as soon as we release a new version, I will uncomment this.
type: Test | ||
spec: | ||
id: yWoVaiuVR | ||
name: Your API call with error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the error in this case? All assertions are waiting 200 OK
status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth adding a description
to the test to explain the usecase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to add a description. This is a test that is expected to fail, to simulate the problem that I'm presenting on the talk.
Context: https://www.loom.com/share/ab3579b2f5fa4fd4af58e088bcad8513?t=852&sid=2b4e5820-2e11-4e42-a9ae-08f33a594e36 (at the 14 min of the talk)
* add upsert method and enable it for environments * handle error when getting entity
* Adding initial APIs for the example * Adding code for payment-executor-api * Adding full example * Adding trace-based tests * Updating README * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> * Adding documentation to the example * fix(backend): matching trigger span duration and trigger time durations (#2740) * fix(frontend): adding default value for data store connection types (#2742) * fix(backend): fixing response status code for grpc request (#2741) * feat: add upsert method and enable it for environments (#2746) * add upsert method and enable it for environments * handle error when getting entity * PR suggestions --------- Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Oscar Reyes <[email protected]> Co-authored-by: Matheus Nogueira <[email protected]>
* Adding initial APIs for the example * Adding code for payment-executor-api * Adding full example * Adding trace-based tests * Updating README * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> * Adding documentation to the example * fix(backend): matching trigger span duration and trigger time durations (#2740) * fix(frontend): adding default value for data store connection types (#2742) * fix(backend): fixing response status code for grpc request (#2741) * feat: add upsert method and enable it for environments (#2746) * add upsert method and enable it for environments * handle error when getting entity * PR suggestions --------- Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Oscar Reyes <[email protected]> Co-authored-by: Matheus Nogueira <[email protected]>
This PR adds a new example called "Observability to the Rescue! Monitoring and testing APIs with OpenTelemetry".
Loom: https://www.loom.com/share/9a5bdadfafc2417bb4534bb73487b0c6?sid=4116c7ed-5683-4bc6-8c31-deef4aadf896
Changes
Checklist