chore(server): refactoring analyzer files to comply with resources standard #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
reviewed
Jun 22, 2023
server/executor/linter_runner.go
Outdated
| @@ -8,7 +8,7 @@ import ( | |||
|
|
|||
| "github.com/kubeshop/tracetest/server/analytics" | |||
| "github.com/kubeshop/tracetest/server/linter" | |||
| linterResource "github.com/kubeshop/tracetest/server/linter/resource" | |||
| analyzerResource "github.com/kubeshop/tracetest/server/linter/analyzer" | |||
There was a problem hiding this comment.
should this be just analyzer? is there a reason for the alias?
There was a problem hiding this comment.
Good catch! I'll update it.
server/app/app.go
Outdated
| @@ -24,7 +24,7 @@ import ( | |||
| httpServer "github.com/kubeshop/tracetest/server/http" | |||
| "github.com/kubeshop/tracetest/server/http/mappings" | |||
| "github.com/kubeshop/tracetest/server/http/websocket" | |||
| linterResource "github.com/kubeshop/tracetest/server/linter/resource" | |||
| analyzer "github.com/kubeshop/tracetest/server/linter/analyzer" | |||
There was a problem hiding this comment.
no need to use the alias if the alias has the same name as the package. You can remove them all
There was a problem hiding this comment.
Thanks! Also updating it.
mathnogueira
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the analyzer files to comply with the resource standard.