feat: Add Signoz as a Datastore #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
commented
Jul 13, 2023
There was a problem hiding this comment.
Added this documentation just to avoid having a broken link on FE, however, I need to double-check with @adnanrahic and @jfermi on how they created the FE image for this doc.
schoren
reviewed
Jul 13, 2023
There was a problem hiding this comment.
should this file be included?
schoren
approved these changes
Jul 13, 2023
danielbdias
commented
Jul 13, 2023
There was a problem hiding this comment.
The files on this signoz folder are the same files of the Signoz GitHub here, used to spin up the server with docker. I believe that we can refer them in the future, instead of having them here we should try to download them from their GitHub.
xoscar
approved these changes
Jul 13, 2023
Sure! Added it on the last commit. |
|
Thanks for support :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Signoz as a DataStore on Tracetest.
Initial exploration Loom: https://www.loom.com/share/e31224e711654f1ca3cfe054c465a9b7
Changes
tracetest-signozexampleChecklist