feat: add Dynatrace datasource #2989

agardnerIT · 2023-07-27T05:31:16Z

This PR adds Dynatrace as a DataStore to Tracetest.

Changes

Adds Dynatrace as a datasource

Checklist

[] tested locally
added new dependencies
updated the docs
added a test

Signed-off-by: Adam Gardner <[email protected]>

examples/tracetest-dynatrace/tracetest/tracetest-provision.yaml

docs/docs/examples-tutorials/recipes/running-tracetest-with-dynatrace.md

web/src/constants/DataStore.constants.tsx

kdhamric

Marked a couple spots that may need correction

danielbdias

hi @agardnerIT ! thanks for your contribution! 😄
I've added some comments that we can improve on this PR. Does them make sense?

docs/docs/examples-tutorials/recipes/running-tracetest-with-dynatrace.md

danielbdias · 2023-07-27T18:31:08Z

docs/docs/examples-tutorials/recipes/running-tracetest-with-dynatrace.md

+
+## Prerequisites
+
+You will need [Docker](https://docs.docker.com/get-docker/) and [Docker Compose](https://docs.docker.com/compose/install/) installed on your machine to run this sample app! Additionally, you will need a Datadog account and an API. Sign up to Datadog on their [homepage](https://www.datadoghq.com/) by clicking on `Get Started Free`.


Suggested change

You will need [Docker](https://docs.docker.com/get-docker/) and [Docker Compose](https://docs.docker.com/compose/install/) installed on your machine to run this sample app! Additionally, you will need a Datadog account and an API. Sign up to Datadog on their [homepage](https://www.datadoghq.com/) by clicking on `Get Started Free`.

You will need [Docker](https://docs.docker.com/get-docker/) and [Docker Compose](https://docs.docker.com/compose/install/) installed on your machine to run this sample app! Additionally, you will need a Datadog account and an API Key. Sign up for Dynatrace on their [homepage](https://www.dynatrace.com/) by clicking on `Free trial`.

@danielbdias is going to review this today. If we can get it knocked out, we may be able to slide it into the RC on Monday and then release on Tuesday!

docs/docs/examples-tutorials/recipes/running-tracetest-with-dynatrace.md

…natrace.md Co-authored-by: Daniel Baptista Dias <[email protected]>

Signed-off-by: Adam Gardner <[email protected]>

agardnerIT · 2023-07-27T23:29:51Z

Really not sure how I missed all of that! Hopefully those new commits resolve all the issues.

danielbdias

Added some comments that can help to fix the CI for the server and frontend. By making these changes, we are ready to go with this PR.

server/tracedb/tracedb_test.go

web/src/components/DataStoreIcon/Icons/Dynatrace.tsx

danielbdias · 2023-07-28T16:28:19Z

api/dataStores.yaml

@@ -194,7 +194,8 @@ components:
          awsxray,
          honeycomb,
          azureappinsights,
-          signoz
+          signoz,
+          dynatrace


Can you run make generate-web to make this change reflect on the Web UI and commit the change on web/src/types/Generated.types.ts?
By doing that the UI CI tasks will run normally and the frontend will build.

Signed-off-by: Adam Gardner <[email protected]>

agardnerIT · 2023-07-31T04:05:34Z

I've fixed the SVG and code comments. Having some trouble running make generate-web.

No windows support
I run in a codespace and download goreleaser pro 1.18.2 then run make generate-web from root and get this:

@agardnerIT ➜ /workspaces/tracetest (add-dt) $ make generate-web
make: Nothing to be done for 'generate-web'.

make goreleaser-version:

make: Nothing to be done for 'goreleaser-version'.

`$ make build-web
cd web; npm run build

[email protected] build
npm run less && craco build

[email protected] less
lessc --js src/antd-theme/antd-customized.less src/antd-theme/antd-customized.css

Creating an optimized production build...
TypeError: Cannot set property mark of # which has only a getter
TypeError: Cannot set property mark of # which has only a getter
at Object.connectTypeScriptPerformance (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/typescript-reporter/profile/TypeScriptPerformance.js:12:36)
at createTypeScriptReporter (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/typescript-reporter/reporter/TypeScriptReporter.js:40:49)
at Object. (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:21:30)
at Generator.next ()
at /workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:8:71
at new Promise ()
at __awaiter (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:4:12)
at /workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:19:88
at Object. (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/rpc/RpcService.js:23:38)
at Generator.next ()
TypeError: Cannot set property mark of # which has only a getter
TypeError: Cannot set property mark of # which has only a getter
at Object.connectTypeScriptPerformance (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/typescript-reporter/profile/TypeScriptPerformance.js:12:36)
at createTypeScriptReporter (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/typescript-reporter/reporter/TypeScriptReporter.js:40:49)
at Object. (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:21:30)
at Generator.next ()
at /workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:8:71
at new Promise ()
at __awaiter (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:4:12)
at /workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/reporter/reporter-rpc/ReporterRpcService.js:19:88
at Object. (/workspaces/tracetest/web/node_modules/fork-ts-checker-webpack-plugin/lib/rpc/RpcService.js:23:38)
at Generator.next ()


Side note: It would be great to have a preconfigured codespace w/ batteries included to help dev.

danielbdias · 2023-07-31T13:48:59Z

Side note: It would be great to have a preconfigured codespace w/ batteries included to help dev.

Thanks for this feedback @agardnerIT ! I will double-check with the team about this.

I will take a look on generate-web and fix that for this PR.

danielbdias · 2023-07-31T14:26:19Z

By adding the generated content, this PR works. I'll merge it and add the generated FE content in another PR.

kdhamric · 2023-07-31T14:47:15Z

Very excited to have this in and released!!!

feat: add Dynatrace datasource

d982bd2

Signed-off-by: Adam Gardner <[email protected]>

kdhamric reviewed Jul 27, 2023

View reviewed changes

examples/tracetest-dynatrace/tracetest/tracetest-provision.yaml Outdated Show resolved Hide resolved

kdhamric reviewed Jul 27, 2023

View reviewed changes

docs/docs/examples-tutorials/recipes/running-tracetest-with-dynatrace.md Outdated Show resolved Hide resolved

kdhamric reviewed Jul 27, 2023

View reviewed changes

web/src/constants/DataStore.constants.tsx Outdated Show resolved Hide resolved

kdhamric reviewed Jul 27, 2023

View reviewed changes

danielbdias reviewed Jul 27, 2023

View reviewed changes

agardnerIT and others added 6 commits July 28, 2023 08:03

Update docs/docs/examples-tutorials/recipes/running-tracetest-with-dy…

9fc97ce

…natrace.md Co-authored-by: Daniel Baptista Dias <[email protected]>

updates

e8f8c28

Signed-off-by: Adam Gardner <[email protected]>

update DataStore constants

2841d6c

Signed-off-by: Adam Gardner <[email protected]>

fix typo

89e73a6

Signed-off-by: Adam Gardner <[email protected]>

export Dynatrace

69bf732

Signed-off-by: Adam Gardner <[email protected]>

update file names

e9c7486

Signed-off-by: Adam Gardner <[email protected]>

danielbdias reviewed Jul 28, 2023

View reviewed changes

address findings

b3e6698

Signed-off-by: Adam Gardner <[email protected]>

danielbdias mentioned this pull request Jul 31, 2023

Create configuration of Github Codespaces to allow users to contributed easily on Tracetest #3005

Open

mathnogueira merged commit 1144c83 into kubeshop:main Jul 31, 2023

agardnerIT deleted the add-dt branch August 1, 2023 02:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Dynatrace datasource #2989

feat: add Dynatrace datasource #2989

agardnerIT commented Jul 27, 2023 •

edited by danielbdias

Loading

kdhamric left a comment

danielbdias left a comment

danielbdias Jul 27, 2023

kdhamric Jul 28, 2023

agardnerIT commented Jul 27, 2023

danielbdias left a comment

danielbdias Jul 28, 2023

agardnerIT commented Jul 31, 2023

danielbdias commented Jul 31, 2023

danielbdias commented Jul 31, 2023

kdhamric commented Jul 31, 2023


		## Prerequisites

		You will need [Docker](https://docs.docker.com/get-docker/) and [Docker Compose](https://docs.docker.com/compose/install/) installed on your machine to run this sample app! Additionally, you will need a Datadog account and an API. Sign up to Datadog on their [homepage](https://www.datadoghq.com/) by clicking on `Get Started Free`.

feat: add Dynatrace datasource #2989

feat: add Dynatrace datasource #2989

Conversation

agardnerIT commented Jul 27, 2023 • edited by danielbdias Loading

Changes

Checklist

kdhamric left a comment

Choose a reason for hiding this comment

danielbdias left a comment

Choose a reason for hiding this comment

danielbdias Jul 27, 2023

Choose a reason for hiding this comment

kdhamric Jul 28, 2023

Choose a reason for hiding this comment

agardnerIT commented Jul 27, 2023

danielbdias left a comment

Choose a reason for hiding this comment

danielbdias Jul 28, 2023

Choose a reason for hiding this comment

agardnerIT commented Jul 31, 2023

danielbdias commented Jul 31, 2023

danielbdias commented Jul 31, 2023

kdhamric commented Jul 31, 2023

agardnerIT commented Jul 27, 2023 •

edited by danielbdias

Loading