Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui, api): adding Kafka example to Pokeshop demo #3086

Merged
merged 5 commits into from
Aug 21, 2023
Merged

chore(ui, api): adding Kafka example to Pokeshop demo #3086

merged 5 commits into from
Aug 21, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Aug 21, 2023 •
edited
Loading

This PR aims to add a Kafka example to the Pokeshop demo, allowing users to test a Kafka trigger quickly.

Loom: https://www.loom.com/share/cc55b4419079472fa4937a4ce6ba61ba

Changes

  • Added KafkaBroker field to OpenAPI specs
  • Added KafkaBroker field to the server
  • Added a new field to Pokeshop Demo on UI
  • Added a new example on Kafka trigger

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@danielbdias danielbdias marked this pull request as ready for review August 21, 2023 15:07
@danielbdias danielbdias merged commit 847caca into main Aug 21, 2023
@danielbdias danielbdias deleted the add/kafka-broker-to-pokeshop-demo branch August 21, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbdias @xoscar