Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): improving relative file detection for protobuf #3091

Merged
merged 6 commits into from
Aug 22, 2023
Merged

fix(cli): improving relative file detection for protobuf #3091

merged 6 commits into from
Aug 22, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Aug 22, 2023 •
edited
Loading

This PR fixes #3090 by improving the relative file detection on gRPC test triggers.

Changes

  • Improve relative file detection on gRPC test triggers

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@danielbdias danielbdias merged commit 4fd1c42 into main Aug 22, 2023
@danielbdias danielbdias deleted the fix/cli-grpc-test-with-protobuf branch August 22, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@xoscar xoscar Awaiting requested review from xoscar

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applying tests with large protobuf schemas return a could not consolidate grpc file error
2 participants
@danielbdias @schoren