fix(agent): fixing connection error check #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Sep 22, 2023
| "github.com/kubeshop/tracetest/server/datastore" | ||
| "github.com/kubeshop/tracetest/server/tracedb" | ||
| "github.com/kubeshop/tracetest/server/tracedb/connection" |
There was a problem hiding this comment.
We are pointing everything to the server trace db logic, in the future we have to kill that package to use the one from the agent, the polling error was caused because of the errorTraceNotFound instance was different between server/tracedb and agent/datastores package
mathnogueira
approved these changes
Sep 22, 2023
schoren
approved these changes
Sep 22, 2023
jorgeepc
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Fixes
Checklist