feat(agent): k8s deployment script #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
commented
Sep 27, 2023
k8s/agent/deploy-agent.yaml
Outdated
| spec: | ||
| containers: | ||
| - name: tracetest-agent | ||
| image: kubeshop/tracetest-agent:v0.13.9 |
There was a problem hiding this comment.
Should we use latest here?
There was a problem hiding this comment.
It may be a good idea. I believe that it is easy to forget to update this version.
danielbdias
approved these changes
Sep 27, 2023
k8s/agent/deploy-agent.yaml
Outdated
| spec: | ||
| containers: | ||
| - name: tracetest-agent | ||
| image: kubeshop/tracetest-agent:v0.13.9 |
There was a problem hiding this comment.
It may be a good idea. I believe that it is easy to forget to update this version.
k8s/agent/deploy-agent.yaml
Outdated
| spec: | ||
| containers: | ||
| - name: tracetest-agent | ||
| image: kubeshop/tracetest-agent:v0.13.9 |
There was a problem hiding this comment.
Thinking also about the version: is there a way to make this version configurable? My idea is to think a way to install a specific version of the agent in a cluster.
There was a problem hiding this comment.
By default, kubeshop/tracetest-agent:latest will be used.
If the user provides a third option with the version, that version will be used instead:
curl <path> | bash -s -- <namespace> <api-key> (<version>?)
xoscar
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the k8s manifest to deploy the agent in a cluster
Checklist