Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples(sumo): improve example and guide #3485

Merged
merged 2 commits into from
Jan 3, 2024
Merged

examples(sumo): improve example and guide #3485

merged 2 commits into from
Jan 3, 2024

Conversation

adnanrahic
Copy link
Contributor

This PR improves the Sumo Logic example app and readme guide.

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@adnanrahic adnanrahic self-assigned this Jan 2, 2024
@adnanrahic adnanrahic requested review from kdhamric and schoren January 2, 2024 18:22
schoren
schoren approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! should we wait for #3490 to be merged before releasing this?

@adnanrahic adnanrahic merged commit 3bb85e2 into main Jan 3, 2024
37 checks passed
@adnanrahic adnanrahic deleted the examples-sumologic-improvements-2 branch January 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdhamric kdhamric kdhamric approved these changes

@schoren schoren schoren approved these changes

Assignees

@adnanrahic adnanrahic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adnanrahic @schoren @kdhamric