Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): E2E docs fix #3528

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(docs): E2E docs fix #3528

merged 1 commit into from
Jan 15, 2024

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Jan 15, 2024

This PR fixes a couple issues with the e2e docs for the name of the environment variables file and the docker compose command.

Changes

  • Fixes wrong content for e2e docs

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Jan 15, 2024
@xoscar xoscar requested review from adnanrahic and kdhamric January 15, 2024 21:24
@xoscar xoscar marked this pull request as ready for review January 15, 2024 21:25
kdhamric
kdhamric approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@kdhamric kdhamric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@xoscar xoscar merged commit 18f01ec into main Jan 15, 2024
37 checks passed
@xoscar xoscar deleted the fix-e2e-docs branch January 15, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdhamric kdhamric kdhamric approved these changes

@adnanrahic adnanrahic Awaiting requested review from adnanrahic

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @kdhamric