fix(cli): automatically use cloud endpoint if token is passed #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server-url is set
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schoren
commented
Feb 21, 2024
| @@ -11,7 +11,6 @@ ifneq "$(CURRENT_GORELEASER_VERSION)" "$(GORELEASER_VERSION)" | |||
| @printf "\033[0;31m Bad goreleaser version $(CURRENT_GORELEASER_VERSION), please install $(GORELEASER_VERSION)\033[0m\n\n" | |||
| @printf "\033[0;31m Tracetest requires goreleaser pro installed (licence not necessary for local builds)\033[0m\n\n" | |||
| @printf "\033[0;33m See https://goreleaser.com/install/ \033[0m\n\n" | |||
| @exit 1 | |||
There was a problem hiding this comment.
i want to know if we're outdated, but let's keep the builds rolling.
schoren
commented
Feb 21, 2024
| @@ -187,8 +190,8 @@ func (c Configurator) populateConfigWithDevConfig(ctx context.Context, cfg *Conf | |||
| } | |||
|
|
|||
| func (c Configurator) populateConfigWithVersionInfo(ctx context.Context, cfg Config) (_ Config, _ error, isOSS bool) { | |||
| cliVersion := Version | |||
| if cliVersion == "dev" { | |||
| useDevVersion := os.Getenv("TRACETEST_AGENT_DEV_CONFIG") == "true" | |||
There was a problem hiding this comment.
it took me a good 20 mins of debuggin to figure out this was happening. So I changed the behavior to be opt in by passing an env var. Otherwise it might hide issues with our config logic during development
jorgeepc
approved these changes
Feb 21, 2024
xoscar
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the CLI not ask interactively from the user the desired server URL, and instead automatically select one.
When passing
--tokenor--api-keywe can no longer asume an interactive environment. Those tokens are usually used in a CI or otherwise automated environment, where user interaction is not available.In this case, server url is chose as:
--server-urlflag is passed, used that.This behaviour was already implemented for the
--tokenflag, but not for the--api-keyflag.