Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Agent image to support node and update OpenAPI specs #3924

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Update Agent image to support node and update OpenAPI specs #3924

merged 4 commits into from
Jul 8, 2024

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Jul 5, 2024 •
edited
Loading

This PR updates the tracetest agent image to run node scripts.

How to test:

make build-docker

docker run --entrypoint sh --env TRACETEST_API_KEY=test --rm -it kubeshop/tracetest-agent:dev

node --version
npm --version
npx --version

Changes

  • Update agent image
  • Update OpenAPI files
  • Update web and server to comply with OpenAPI files

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 8:20pm

danielbdias
danielbdias commented Jul 5, 2024
View reviewed changes
Dockerfile.agent
Comment on lines +13 to +14
# Setup additional runtimes used by triggers
RUN apk add nodejs npm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the relevant change for this PR.

@danielbdias danielbdias marked this pull request as ready for review July 7, 2024 21:45
@danielbdias danielbdias changed the title Update/agent image Update Agent image to support node and update OpenAPI specs Jul 8, 2024
@danielbdias danielbdias merged commit 397b26b into main Jul 8, 2024
38 checks passed
@danielbdias danielbdias deleted the update/agent-image branch July 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbdias @xoscar